Skip to content

Commit

Permalink
lockdep, UML: fix compilation when CONFIG_TRACE_IRQFLAGS_SUPPORT is n…
Browse files Browse the repository at this point in the history
…ot set

Hiroshi Shimamoto reported:

> > !TRACE_IRQFLAGS_SUPPORT mode of build for future work, it can be
> > restored via a simple revert.
>
> Hi, it seems that this patch breaks uml build.
>
> kernel/printk.c: In function 'vprintk':
> kernel/printk.c:674: error: implicit declaration of function
> 'raw_local_irq_save' kernel/printk.c:772: error: implicit declaration of
> function 'raw_local_irq_restore'

With the patch bellow it compiles (make ARCH=um with a x86 host), but I'm
really out of my league on this one...

Reported-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Rui Sousa authored and Ingo Molnar committed Sep 5, 2008
1 parent cdad722 commit 8c56250
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions include/asm-um/system-generic.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
#include "asm/arch/system.h"

#undef switch_to
#undef local_irq_save
#undef local_irq_restore
#undef local_irq_disable
#undef local_irq_enable
#undef local_save_flags
#undef local_irq_restore
#undef local_irq_enable
#undef local_irq_disable
#undef local_irq_save
#undef raw_local_irq_save
#undef raw_local_irq_restore
#undef raw_local_irq_disable
#undef raw_local_irq_enable
#undef raw_local_save_flags
#undef raw_local_irq_restore
#undef raw_local_irq_enable
#undef raw_local_irq_disable
#undef raw_local_irq_save
#undef irqs_disabled

extern void *switch_to(void *prev, void *next, void *last);
Expand All @@ -23,21 +23,21 @@ extern int get_signals(void);
extern void block_signals(void);
extern void unblock_signals(void);

#define local_save_flags(flags) do { typecheck(unsigned long, flags); \
#define raw_local_save_flags(flags) do { typecheck(unsigned long, flags); \
(flags) = get_signals(); } while(0)
#define local_irq_restore(flags) do { typecheck(unsigned long, flags); \
#define raw_local_irq_restore(flags) do { typecheck(unsigned long, flags); \
set_signals(flags); } while(0)

#define local_irq_save(flags) do { local_save_flags(flags); \
local_irq_disable(); } while(0)
#define raw_local_irq_save(flags) do { raw_local_save_flags(flags); \
raw_local_irq_disable(); } while(0)

#define local_irq_enable() unblock_signals()
#define local_irq_disable() block_signals()
#define raw_local_irq_enable() unblock_signals()
#define raw_local_irq_disable() block_signals()

#define irqs_disabled() \
({ \
unsigned long flags; \
local_save_flags(flags); \
raw_local_save_flags(flags); \
(flags == 0); \
})

Expand Down

0 comments on commit 8c56250

Please sign in to comment.