Skip to content

Commit

Permalink
[IPoIB] no need to set skb->dev right before freeing skb
Browse files Browse the repository at this point in the history
For cut-and-paste reasons, the IPoIB driver was setting skb->dev right
before calling dev_kfree_skb_any().  Get rid of this.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Roland Dreier committed Nov 10, 2005
1 parent 2f76e82 commit 8c608a3
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions drivers/infiniband/ulp/ipoib/ipoib_multicast.c
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,8 @@ static void ipoib_mcast_free(struct ipoib_mcast *mcast)
if (mcast->ah)
ipoib_put_ah(mcast->ah);

while (!skb_queue_empty(&mcast->pkt_queue)) {
struct sk_buff *skb = skb_dequeue(&mcast->pkt_queue);

skb->dev = dev;
dev_kfree_skb_any(skb);
}
while (!skb_queue_empty(&mcast->pkt_queue))
dev_kfree_skb_any(skb_dequeue(&mcast->pkt_queue));

kfree(mcast);
}
Expand Down Expand Up @@ -317,13 +313,8 @@ ipoib_mcast_sendonly_join_complete(int status,
IPOIB_GID_ARG(mcast->mcmember.mgid), status);

/* Flush out any queued packets */
while (!skb_queue_empty(&mcast->pkt_queue)) {
struct sk_buff *skb = skb_dequeue(&mcast->pkt_queue);

skb->dev = dev;

dev_kfree_skb_any(skb);
}
while (!skb_queue_empty(&mcast->pkt_queue))
dev_kfree_skb_any(skb_dequeue(&mcast->pkt_queue));

/* Clear the busy flag so we try again */
clear_bit(IPOIB_MCAST_FLAG_BUSY, &mcast->flags);
Expand Down

0 comments on commit 8c608a3

Please sign in to comment.