Skip to content

Commit

Permalink
ext4: don't pass freed handle to ext4_walk_page_buffers
Browse files Browse the repository at this point in the history
This is harmless, since ext4_walk_page_buffers only passes the handle
onto the callback function, and in this call site the function in
question, bput_one(), doesn't actually use the handle.  But there's no
point passing in an invalid handle, and it creates a Coverity warning,
so let's just clean it up.

Addresses-Coverity-Id: #1091168

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Theodore Ts'o committed Jan 7, 2014
1 parent 09c455a commit 8c9367f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/ext4/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -1772,7 +1772,7 @@ static int __ext4_journalled_writepage(struct page *page,
ret = err;

if (!ext4_has_inline_data(inode))
ext4_walk_page_buffers(handle, page_bufs, 0, len,
ext4_walk_page_buffers(NULL, page_bufs, 0, len,
NULL, bput_one);
ext4_set_inode_state(inode, EXT4_STATE_JDATA);
out:
Expand Down

0 comments on commit 8c9367f

Please sign in to comment.