Skip to content

Commit

Permalink
[media] go7007: dubious one-bit signed bitfields
Browse files Browse the repository at this point in the history
Because they're signed, "is_video" and "is_audio" can be 0 and -1
instead of 0 and 1 as intended.  It doesn't cause a bug, but it makes
Sparse complain:
drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield
drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Dan Carpenter authored and Mauro Carvalho Chehab committed Apr 22, 2013
1 parent 5ddfbbb commit 8c93c40
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/media/go7007/go7007-priv.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ struct go7007_board_info {
int num_i2c_devs;
struct go_i2c {
const char *type;
int is_video:1;
int is_audio:1;
unsigned int is_video:1;
unsigned int is_audio:1;
int addr;
u32 flags;
} i2c_devs[5];
Expand Down

0 comments on commit 8c93c40

Please sign in to comment.