Skip to content

Commit

Permalink
Staging: hv: Fix argument order in incorrect memset invocations in hy…
Browse files Browse the repository at this point in the history
…perv driver.

Nearly every invocation of memset in drivers/staging/hv/StorVsc.c has
its arguments the wrong way around.

Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Dave Jones authored and Greg Kroah-Hartman committed Dec 1, 2009
1 parent a8a8454 commit 8c960e4
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/staging/hv/StorVsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ static int StorVscChannelInit(struct hv_device *Device)
* Now, initiate the vsc/vsp initialization protocol on the open
* channel
*/
memset(request, sizeof(struct storvsc_request_extension), 0);
memset(request, 0, sizeof(struct storvsc_request_extension));
request->WaitEvent = osd_WaitEventCreate();

vstorPacket->Operation = VStorOperationBeginInitialization;
Expand Down Expand Up @@ -233,7 +233,7 @@ static int StorVscChannelInit(struct hv_device *Device)
DPRINT_INFO(STORVSC, "QUERY_PROTOCOL_VERSION_OPERATION...");

/* reuse the packet for version range supported */
memset(vstorPacket, sizeof(struct vstor_packet), 0);
memset(vstorPacket, 0, sizeof(struct vstor_packet));
vstorPacket->Operation = VStorOperationQueryProtocolVersion;
vstorPacket->Flags = REQUEST_COMPLETION_FLAG;

Expand Down Expand Up @@ -266,7 +266,7 @@ static int StorVscChannelInit(struct hv_device *Device)
/* Query channel properties */
DPRINT_INFO(STORVSC, "QUERY_PROPERTIES_OPERATION...");

memset(vstorPacket, sizeof(struct vstor_packet), 0);
memset(vstorPacket, 0, sizeof(struct vstor_packet));
vstorPacket->Operation = VStorOperationQueryProperties;
vstorPacket->Flags = REQUEST_COMPLETION_FLAG;
vstorPacket->StorageChannelProperties.PortNumber =
Expand Down Expand Up @@ -305,7 +305,7 @@ static int StorVscChannelInit(struct hv_device *Device)

DPRINT_INFO(STORVSC, "END_INITIALIZATION_OPERATION...");

memset(vstorPacket, sizeof(struct vstor_packet), 0);
memset(vstorPacket, 0, sizeof(struct vstor_packet));
vstorPacket->Operation = VStorOperationEndInitialization;
vstorPacket->Flags = REQUEST_COMPLETION_FLAG;

Expand Down Expand Up @@ -508,7 +508,7 @@ static int StorVscConnectToVsp(struct hv_device *Device)
int ret;

storDriver = (struct storvsc_driver_object *)Device->Driver;
memset(&props, sizeof(struct vmstorage_channel_properties), 0);
memset(&props, 0, sizeof(struct vmstorage_channel_properties));

/* Open the channel */
ret = Device->Driver->VmbusChannelInterface.Open(Device,
Expand Down

0 comments on commit 8c960e4

Please sign in to comment.