Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 233704
b: refs/heads/master
c: fe41947
h: refs/heads/master
v: v3
  • Loading branch information
Alexandre Bounine authored and Linus Torvalds committed Feb 25, 2011
1 parent bd28240 commit 8ca5517
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 99b0d365e5ade293c5fa25a9f1a49ac764656670
refs/heads/master: fe41947e1aa12e96a50edaee123b4e4de03b668b
12 changes: 6 additions & 6 deletions trunk/drivers/rapidio/rio-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ rio_read_config(struct file *filp, struct kobject *kobj,

/* Several chips lock up trying to read undefined config space */
if (capable(CAP_SYS_ADMIN))
size = 0x200000;
size = RIO_MAINT_SPACE_SZ;

if (off > size)
if (off >= size)
return 0;
if (off + count > size) {
size -= off;
Expand Down Expand Up @@ -147,10 +147,10 @@ rio_write_config(struct file *filp, struct kobject *kobj,
loff_t init_off = off;
u8 *data = (u8 *) buf;

if (off > 0x200000)
if (off >= RIO_MAINT_SPACE_SZ)
return 0;
if (off + count > 0x200000) {
size = 0x200000 - off;
if (off + count > RIO_MAINT_SPACE_SZ) {
size = RIO_MAINT_SPACE_SZ - off;
count = size;
}

Expand Down Expand Up @@ -200,7 +200,7 @@ static struct bin_attribute rio_config_attr = {
.name = "config",
.mode = S_IRUGO | S_IWUSR,
},
.size = 0x200000,
.size = RIO_MAINT_SPACE_SZ,
.read = rio_read_config,
.write = rio_write_config,
};
Expand Down
4 changes: 3 additions & 1 deletion trunk/include/linux/rio_regs.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@
#define LINUX_RIO_REGS_H

/*
* In RapidIO, each device has a 2MB configuration space that is
* In RapidIO, each device has a 16MB configuration space that is
* accessed via maintenance transactions. Portions of configuration
* space are standardized and/or reserved.
*/
#define RIO_MAINT_SPACE_SZ 0x1000000 /* 16MB of RapidIO mainenance space */

#define RIO_DEV_ID_CAR 0x00 /* [I] Device Identity CAR */
#define RIO_DEV_INFO_CAR 0x04 /* [I] Device Information CAR */
#define RIO_ASM_ID_CAR 0x08 /* [I] Assembly Identity CAR */
Expand Down

0 comments on commit 8ca5517

Please sign in to comment.