Skip to content

Commit

Permalink
exofs: remove unnecessary dentry_unhash on rmdir/rename_dir
Browse files Browse the repository at this point in the history
Exofs has no problems with lingering references to unlinked directory
inodes.

CC: Benny Halevy <bhalevy@panasas.com>
CC: osd-dev@open-osd.org
Acked-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Sage Weil authored and Al Viro committed May 26, 2011
1 parent 052e2a1 commit 8cbfa53
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions fs/exofs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,6 @@ static int exofs_rmdir(struct inode *dir, struct dentry *dentry)
struct inode *inode = dentry->d_inode;
int err = -ENOTEMPTY;

dentry_unhash(dentry);

if (exofs_empty_dir(inode)) {
err = exofs_unlink(dir, dentry);
if (!err) {
Expand All @@ -251,9 +249,6 @@ static int exofs_rename(struct inode *old_dir, struct dentry *old_dentry,
struct exofs_dir_entry *old_de;
int err = -ENOENT;

if (new_inode && S_ISDIR(new_inode->i_mode))
dentry_unhash(new_dentry);

old_de = exofs_find_entry(old_dir, old_dentry, &old_page);
if (!old_de)
goto out;
Expand Down

0 comments on commit 8cbfa53

Please sign in to comment.