Skip to content

Commit

Permalink
ASoC: es8328: Cleanup manual bias level transitions
Browse files Browse the repository at this point in the history
Set the CODEC driver's suspend_bias_off flag rather than manually going to
SND_SOC_BIAS_OFF in suspend and SND_SOC_BIAS_STANDBY in resume. This makes
the code a bit shorter and cleaner.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Mark Brown committed Sep 6, 2014
1 parent bade5f0 commit 8d01370
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions sound/soc/codecs/es8328.c
Original file line number Diff line number Diff line change
Expand Up @@ -602,8 +602,6 @@ static int es8328_suspend(struct snd_soc_codec *codec)

es8328 = snd_soc_codec_get_drvdata(codec);

es8328_set_bias_level(codec, SND_SOC_BIAS_OFF);

clk_disable_unprepare(es8328->clk);

ret = regulator_bulk_disable(ARRAY_SIZE(es8328->supplies),
Expand Down Expand Up @@ -643,7 +641,6 @@ static int es8328_resume(struct snd_soc_codec *codec)
return ret;
}

es8328_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
return 0;
}

Expand Down Expand Up @@ -712,6 +709,8 @@ static struct snd_soc_codec_driver es8328_codec_driver = {
.resume = es8328_resume,
.remove = es8328_remove,
.set_bias_level = es8328_set_bias_level,
.suspend_bias_off = true,

.controls = es8328_snd_controls,
.num_controls = ARRAY_SIZE(es8328_snd_controls),
.dapm_widgets = es8328_dapm_widgets,
Expand Down

0 comments on commit 8d01370

Please sign in to comment.