Skip to content

Commit

Permalink
ftrace: Remove a superfluous check
Browse files Browse the repository at this point in the history
register_ftrace_function() checks ftrace_disabled and calls
__register_ftrace_function which does it again.

Drop the first check and add the unlikely hint to the second one. Also,
drop the label as John correctly notices.

No functional change.

Link: http://lkml.kernel.org/r/20120329171140.GE6409@aftab

Cc: Borislav Petkov <bp@amd64.org>
Cc: John Kacur <jkacur@redhat.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Borislav Petkov authored and Steven Rostedt committed Jun 14, 2012
1 parent e2b297f commit 8d240dd
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions kernel/trace/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ static int remove_ftrace_list_ops(struct ftrace_ops **list,

static int __register_ftrace_function(struct ftrace_ops *ops)
{
if (ftrace_disabled)
if (unlikely(ftrace_disabled))
return -ENODEV;

if (FTRACE_WARN_ON(ops == &global_ops))
Expand Down Expand Up @@ -4299,16 +4299,12 @@ int register_ftrace_function(struct ftrace_ops *ops)

mutex_lock(&ftrace_lock);

if (unlikely(ftrace_disabled))
goto out_unlock;

ret = __register_ftrace_function(ops);
if (!ret)
ret = ftrace_startup(ops, 0);


out_unlock:
mutex_unlock(&ftrace_lock);

return ret;
}
EXPORT_SYMBOL_GPL(register_ftrace_function);
Expand Down

0 comments on commit 8d240dd

Please sign in to comment.