Skip to content

Commit

Permalink
staging: ath6kl: use free_netdev(netdev) instead of kfree()
Browse files Browse the repository at this point in the history
It is not guaranteed that free_netdev() is macro.
Freeing netdev without free_netdev() leads to net, tx leaks.
I might lead to dereferencing freed pointer.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Vasiliy Kulikov authored and Greg Kroah-Hartman committed Sep 30, 2010
1 parent 2166abe commit 8db3271
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/staging/ath6kl/os/linux/ar6000_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -2143,11 +2143,7 @@ ar6000_destroy(struct net_device *dev, unsigned int unregister)
unregister_netdev(dev);
is_netdev_registered = 0;
}
#ifndef free_netdev
kfree(dev);
#else
free_netdev(dev);
#endif

#ifdef ATH6K_CONFIG_CFG80211
ar6k_cfg80211_deinit(ar);
Expand Down Expand Up @@ -6429,11 +6425,7 @@ A_STATUS ar6000_remove_ap_interface(AR_SOFTC_T *ar)
ar6000_stop_ap_interface(ar);

unregister_netdev(arApNetDev);
#ifndef free_netdev
kfree(arApNetDev);
#else
free_netdev(apApNetDev);
#endif

A_PRINTF("Remove AP interface\n");
}
Expand Down

0 comments on commit 8db3271

Please sign in to comment.