Skip to content

Commit

Permalink
edac: e752x fsb ecc
Browse files Browse the repository at this point in the history
FSB parity is only supported on the Xeon processor.  Previously it was
incorrectly enabled for the Celeron as well.

Signed-off-by: Konstantin Olifer <kolifer@gmail.com>
Signed-off-by: Doug Thompson <dougthompson@xmission.com>
Cc: Peter Tyser <ptyser@xes-inc.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Konstantin Olifer authored and Linus Torvalds committed Mar 12, 2010
1 parent 66ed3f7 commit 8de5c1a
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/edac/e752x_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1073,10 +1073,7 @@ static int e752x_get_devs(struct pci_dev *pdev, int dev_idx,

/* Setup system bus parity mask register.
* Sysbus parity supported on:
* e7320/e7520/e7525 + Xeon
* i3100 + Xeon/Celeron
* Sysbus parity not supported on:
* i3100 + Pentium M/Celeron M/Core Duo/Core2 Duo
* e7320/e7520/e7525 + Xeon
*/
static void e752x_init_sysbus_parity_mask(struct e752x_pvt *pvt)
{
Expand All @@ -1087,10 +1084,7 @@ static void e752x_init_sysbus_parity_mask(struct e752x_pvt *pvt)
/* Allow module parameter override, else see if CPU supports parity */
if (sysbus_parity != -1) {
enable = sysbus_parity;
} else if (cpu_id[0] &&
((strstr(cpu_id, "Pentium") && strstr(cpu_id, " M ")) ||
(strstr(cpu_id, "Celeron") && strstr(cpu_id, " M ")) ||
(strstr(cpu_id, "Core") && strstr(cpu_id, "Duo")))) {
} else if (cpu_id[0] && !strstr(cpu_id, "Xeon")) {
e752x_printk(KERN_INFO, "System Bus Parity not "
"supported by CPU, disabling\n");
enable = 0;
Expand Down

0 comments on commit 8de5c1a

Please sign in to comment.