[PATCH] module: strlen_user() race fix

Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
git-mirror · Feb 8, 2006 · 8e08b75 · 8e08b75
1 parent 48b8c10
commit 8e08b75
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/kernel/module.c b/kernel/module.c
@@ -1670,6 +1670,9 @@ static struct module *load_module(void __user *umod,
 		goto free_mod;
 	}
 
+	/* Userspace could have altered the string after the strlen_user() */
+	args[arglen - 1] = '\0';
+
 	if (find_module(mod->name)) {
 		err = -EEXIST;
 		goto free_mod;