Skip to content

Commit

Permalink
scripts/tags.sh: fix DEFINE_HASHTABLE in emacs case
Browse files Browse the repository at this point in the history
The emacs --regex for DEFINE_HASHTABLE produced a warning because of
an unmatched '\('.  Further, the whole entry did not work, because the
regex needs to match from the beginning of a line, including keywords
like 'static'.  Finally, '\w' should not be used, because it
stops at underscores which are often part of variable names in C,
resulting in wrong entries in the tags file.

Signed-off-by: Dirk Gouders <dirk@gouders.net>
Inspired-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
  • Loading branch information
Dirk Gouders authored and Michal Marek committed Aug 19, 2014
1 parent a60113d commit 8e17065
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/tags.sh
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ emacs()
--regex='/_PE(\([^,)]*\).*/PEVENT_ERRNO__\1/' \
--regex='/PCI_OP_READ(\([a-z]*[a-z]\).*[1-4])/pci_bus_read_config_\1/' \
--regex='/PCI_OP_WRITE(\([a-z]*[a-z]\).*[1-4])/pci_bus_write_config_\1/'\
--regex='/DEFINE_HASHTABLE\((\w*)/\1/'
--regex='/[^#]*DEFINE_HASHTABLE(\([^,)]*\)/\1/'

all_kconfigs | xargs $1 -a \
--regex='/^[ \t]*\(\(menu\)*config\)[ \t]+\([a-zA-Z0-9_]+\)/\3/'
Expand Down

0 comments on commit 8e17065

Please sign in to comment.