Skip to content

Commit

Permalink
reiserfs: dont use BUG when panicking
Browse files Browse the repository at this point in the history
Change reiserfs_panic() to use panic() initially instead of BUG().  Using
BUG() ignores the configurable panic behavior, so systems that should be
failing and rebooting are left hanging.  This causes problems in
active/standby HA scenarios.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jeff Mahoney authored and Linus Torvalds committed Oct 19, 2007
1 parent 7598392 commit 8e186e4
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions fs/reiserfs/prints.c
Original file line number Diff line number Diff line change
Expand Up @@ -356,13 +356,11 @@ extern struct tree_balance *cur_tb;
void reiserfs_panic(struct super_block *sb, const char *fmt, ...)
{
do_reiserfs_warning(fmt);
printk(KERN_EMERG "REISERFS: panic (device %s): %s\n",
reiserfs_bdevname(sb), error_buf);
BUG();

/* this is not actually called, but makes reiserfs_panic() "noreturn" */
panic("REISERFS: panic (device %s): %s\n",
reiserfs_bdevname(sb), error_buf);
dump_stack();

panic(KERN_EMERG "REISERFS: panic (device %s): %s\n",
reiserfs_bdevname(sb), error_buf);
}

void reiserfs_abort(struct super_block *sb, int errno, const char *fmt, ...)
Expand Down

0 comments on commit 8e186e4

Please sign in to comment.