Skip to content

Commit

Permalink
drivers/serial/ucc_uart.c: Add missing call to init UCC UART port tim…
Browse files Browse the repository at this point in the history
…eout

The UCC UART driver is missing a call to uart_update_timeout().
Without this call, attempting to close the port after outputting large
amounts of data (i.e. using tty and uart buffering) results in long
timeouts before the port will actually be shut down.

For example, cat a large file to a UCC UART port.  With the current
driver, the port will stay open for 30 seconds after the last byte
of data is output.  But with this patch, the port is closed as
expected, just after the data has been output (tx fifos empty).

Signed-off-by: Chuck Meade <chuck@ThePTRGroup.com>
Acked-by: Timur Tabi <timur@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
  • Loading branch information
Chuck Meade authored and Kumar Gala committed Nov 24, 2011
1 parent 895d603 commit 8e18862
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/tty/serial/ucc_uart.c
Original file line number Diff line number Diff line change
Expand Up @@ -963,6 +963,9 @@ static void qe_uart_set_termios(struct uart_port *port,
/* Do we really need a spinlock here? */
spin_lock_irqsave(&port->lock, flags);

/* Update the per-port timeout. */
uart_update_timeout(port, termios->c_cflag, baud);

out_be16(&uccp->upsmr, upsmr);
if (soft_uart) {
out_be16(&uccup->supsmr, supsmr);
Expand Down

0 comments on commit 8e18862

Please sign in to comment.