Skip to content

Commit

Permalink
wl12xx: wrong values are returned in gpio_power_write()
Browse files Browse the repository at this point in the history
Return values were assigned to incorrect var / weren't assigned.
fix it, and defer mutex_lock after the sanity checks.

Signed-off-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Luciano Coelho <coelho@ti.com>
  • Loading branch information
Eliad Peller authored and Luciano Coelho committed Jan 24, 2011
1 parent bbba3e6 commit 8e2de74
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions drivers/net/wireless/wl12xx/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -261,27 +261,25 @@ static ssize_t gpio_power_write(struct file *file,
unsigned long value;
int ret;

mutex_lock(&wl->mutex);

len = min(count, sizeof(buf) - 1);
if (copy_from_user(buf, user_buf, len)) {
ret = -EFAULT;
goto out;
return -EFAULT;
}
buf[len] = '\0';

ret = strict_strtoul(buf, 0, &value);
if (ret < 0) {
wl1271_warning("illegal value in gpio_power");
goto out;
return -EINVAL;
}

mutex_lock(&wl->mutex);

if (value)
wl1271_power_on(wl);
else
wl1271_power_off(wl);

out:
mutex_unlock(&wl->mutex);
return count;
}
Expand Down

0 comments on commit 8e2de74

Please sign in to comment.