Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 375597
b: refs/heads/master
c: 99a41eb
h: refs/heads/master
i:
  375595: cfe1d9a
v: v3
  • Loading branch information
Alex Elder committed May 8, 2013
1 parent 55daeeb commit 8e370aa
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 18 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 30d60ba2f258da24b91edb880338c7178f901de9
refs/heads/master: 99a41ebcee1a1ea0463b1b29d2e888de21a60c66
21 changes: 4 additions & 17 deletions trunk/drivers/block/rbd.c
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ static int rbd_header_from_disk(struct rbd_device *rbd_dev,
* Copy the names, and fill in each snapshot's id
* and size.
*
* Note that rbd_dev_v1_header_read() guarantees the
* Note that rbd_dev_v1_header_info() guarantees the
* ondisk buffer we're working with has
* snap_names_len bytes beyond the end of the
* snapshot id array, this memcpy() is safe.
Expand Down Expand Up @@ -3050,7 +3050,7 @@ static int rbd_obj_read_sync(struct rbd_device *rbd_dev,
* return, the rbd_dev->header field will contain up-to-date
* information about the image.
*/
static int rbd_dev_v1_header_read(struct rbd_device *rbd_dev)
static int rbd_dev_v1_header_info(struct rbd_device *rbd_dev)
{
struct rbd_image_header_ondisk *ondisk = NULL;
u32 snap_count = 0;
Expand Down Expand Up @@ -3105,14 +3105,6 @@ static int rbd_dev_v1_header_read(struct rbd_device *rbd_dev)
return ret;
}

/*
* only read the first part of the ondisk header, without the snaps info
*/
static int rbd_dev_v1_refresh(struct rbd_device *rbd_dev)
{
return rbd_dev_v1_header_read(rbd_dev);
}

/*
* Clear the rbd device's EXISTS flag if the snapshot it's mapped to
* has disappeared from the (just updated) snapshot context.
Expand Down Expand Up @@ -3141,7 +3133,7 @@ static int rbd_dev_refresh(struct rbd_device *rbd_dev)
mapping_size = rbd_dev->mapping.size;
mutex_lock_nested(&ctl_mutex, SINGLE_DEPTH_NESTING);
if (rbd_dev->image_format == 1)
ret = rbd_dev_v1_refresh(rbd_dev);
ret = rbd_dev_v1_header_info(rbd_dev);
else
ret = rbd_dev_v2_refresh(rbd_dev);

Expand Down Expand Up @@ -4467,11 +4459,6 @@ static void rbd_dev_unprobe(struct rbd_device *rbd_dev)
memset(header, 0, sizeof (*header));
}

static int rbd_dev_v1_probe(struct rbd_device *rbd_dev)
{
return rbd_dev_v1_header_read(rbd_dev);
}

static int rbd_dev_v2_probe(struct rbd_device *rbd_dev)
{
int ret;
Expand Down Expand Up @@ -4714,7 +4701,7 @@ static int rbd_dev_image_probe(struct rbd_device *rbd_dev, bool read_only)
goto out_header_name;

if (rbd_dev->image_format == 1)
ret = rbd_dev_v1_probe(rbd_dev);
ret = rbd_dev_v1_header_info(rbd_dev);
else
ret = rbd_dev_v2_probe(rbd_dev);
if (ret)
Expand Down

0 comments on commit 8e370aa

Please sign in to comment.