Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 315429
b: refs/heads/master
c: 30fdd8a
h: refs/heads/master
i:
  315427: 03362ad
v: v3
  • Loading branch information
Jiri Pirko authored and David S. Miller committed Jul 17, 2012
1 parent b2460aa commit 8e3eec5
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 18 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 0c24604b68fc7810d429d6c3657b6f148270e528
refs/heads/master: 30fdd8a082a00126a6feec994e43e8dc12f5bccb
4 changes: 1 addition & 3 deletions trunk/drivers/net/bonding/bond_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1240,9 +1240,7 @@ static inline int slave_enable_netpoll(struct slave *slave)
if (!np)
goto out;

np->dev = slave->dev;
strlcpy(np->dev_name, slave->dev->name, IFNAMSIZ);
err = __netpoll_setup(np);
err = __netpoll_setup(np, slave->dev);
if (err) {
kfree(np);
goto out;
Expand Down
2 changes: 1 addition & 1 deletion trunk/include/linux/netpoll.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct netpoll_info {
void netpoll_send_udp(struct netpoll *np, const char *msg, int len);
void netpoll_print_options(struct netpoll *np);
int netpoll_parse_options(struct netpoll *np, char *opt);
int __netpoll_setup(struct netpoll *np);
int __netpoll_setup(struct netpoll *np, struct net_device *ndev);
int netpoll_setup(struct netpoll *np);
int netpoll_trap(void);
void netpoll_set_trap(int trap);
Expand Down
5 changes: 1 addition & 4 deletions trunk/net/8021q/vlan_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -681,10 +681,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n
if (!netpoll)
goto out;

netpoll->dev = real_dev;
strlcpy(netpoll->dev_name, real_dev->name, IFNAMSIZ);

err = __netpoll_setup(netpoll);
err = __netpoll_setup(netpoll, real_dev);
if (err) {
kfree(netpoll);
goto out;
Expand Down
5 changes: 1 addition & 4 deletions trunk/net/bridge/br_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,7 @@ int br_netpoll_enable(struct net_bridge_port *p)
if (!np)
goto out;

np->dev = p->dev;
strlcpy(np->dev_name, p->dev->name, IFNAMSIZ);

err = __netpoll_setup(np);
err = __netpoll_setup(np, p->dev);
if (err) {
kfree(np);
goto out;
Expand Down
10 changes: 5 additions & 5 deletions trunk/net/core/netpoll.c
Original file line number Diff line number Diff line change
Expand Up @@ -715,14 +715,16 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
}
EXPORT_SYMBOL(netpoll_parse_options);

int __netpoll_setup(struct netpoll *np)
int __netpoll_setup(struct netpoll *np, struct net_device *ndev)
{
struct net_device *ndev = np->dev;
struct netpoll_info *npinfo;
const struct net_device_ops *ops;
unsigned long flags;
int err;

np->dev = ndev;
strlcpy(np->dev_name, ndev->name, IFNAMSIZ);

if ((ndev->priv_flags & IFF_DISABLE_NETPOLL) ||
!ndev->netdev_ops->ndo_poll_controller) {
np_err(np, "%s doesn't support polling, aborting\n",
Expand Down Expand Up @@ -851,13 +853,11 @@ int netpoll_setup(struct netpoll *np)
np_info(np, "local IP %pI4\n", &np->local_ip);
}

np->dev = ndev;

/* fill up the skb queue */
refill_skbs();

rtnl_lock();
err = __netpoll_setup(np);
err = __netpoll_setup(np, ndev);
rtnl_unlock();

if (err)
Expand Down

0 comments on commit 8e3eec5

Please sign in to comment.