Skip to content

Commit

Permalink
MIPS: RB532: Be sure to clamp return value
Browse files Browse the repository at this point in the history
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mips@linux-mips.org
Cc: linux-gpio@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/11924/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Linus Walleij authored and Ralf Baechle committed Jan 24, 2016
1 parent 6ea6b7f commit 8eb248f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/mips/rb532/gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ static int rb532_gpio_get(struct gpio_chip *chip, unsigned offset)
struct rb532_gpio_chip *gpch;

gpch = container_of(chip, struct rb532_gpio_chip, chip);
return rb532_get_bit(offset, gpch->regbase + GPIOD);
return !!rb532_get_bit(offset, gpch->regbase + GPIOD);
}

/*
Expand Down

0 comments on commit 8eb248f

Please sign in to comment.