Skip to content

Commit

Permalink
[DLM] change some log_error to log_debug
Browse files Browse the repository at this point in the history
Some common, non-error messages should use log_debug instead of log_error
so they can be turned off.

Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
David Teigland authored and Steven Whitehouse committed Feb 5, 2007
1 parent 87d21e0 commit 8ec6886
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions fs/dlm/rcom.c
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ static int is_old_reply(struct dlm_ls *ls, struct dlm_rcom *rc)
seq = ls->ls_recover_seq;
spin_unlock(&ls->ls_recover_lock);
if (rc->rc_seq_reply != seq) {
log_error(ls, "ignoring old reply %x from %d "
log_debug(ls, "ignoring old reply %x from %d "
"seq_reply %llx expect %llx",
rc->rc_type, rc->rc_header.h_nodeid,
(unsigned long long)rc->rc_seq_reply,
Expand Down Expand Up @@ -469,7 +469,7 @@ void dlm_receive_rcom(struct dlm_header *hd, int nodeid)
}

if (dlm_recovery_stopped(ls) && (rc->rc_type != DLM_RCOM_STATUS)) {
log_error(ls, "ignoring recovery message %x from %d",
log_debug(ls, "ignoring recovery message %x from %d",
rc->rc_type, nodeid);
goto out;
}
Expand Down
22 changes: 11 additions & 11 deletions fs/dlm/recoverd.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv)

error = dlm_recover_members(ls, rv, &neg);
if (error) {
log_error(ls, "recover_members failed %d", error);
log_debug(ls, "recover_members failed %d", error);
goto fail;
}
start = jiffies;
Expand All @@ -89,7 +89,7 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv)

error = dlm_recover_directory(ls);
if (error) {
log_error(ls, "recover_directory failed %d", error);
log_debug(ls, "recover_directory failed %d", error);
goto fail;
}

Expand All @@ -99,7 +99,7 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv)

error = dlm_recover_directory_wait(ls);
if (error) {
log_error(ls, "recover_directory_wait failed %d", error);
log_debug(ls, "recover_directory_wait failed %d", error);
goto fail;
}

Expand Down Expand Up @@ -129,7 +129,7 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv)

error = dlm_recover_masters(ls);
if (error) {
log_error(ls, "recover_masters failed %d", error);
log_debug(ls, "recover_masters failed %d", error);
goto fail;
}

Expand All @@ -139,13 +139,13 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv)

error = dlm_recover_locks(ls);
if (error) {
log_error(ls, "recover_locks failed %d", error);
log_debug(ls, "recover_locks failed %d", error);
goto fail;
}

error = dlm_recover_locks_wait(ls);
if (error) {
log_error(ls, "recover_locks_wait failed %d", error);
log_debug(ls, "recover_locks_wait failed %d", error);
goto fail;
}

Expand All @@ -166,7 +166,7 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv)

error = dlm_recover_locks_wait(ls);
if (error) {
log_error(ls, "recover_locks_wait failed %d", error);
log_debug(ls, "recover_locks_wait failed %d", error);
goto fail;
}
}
Expand All @@ -184,27 +184,27 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv)
dlm_set_recover_status(ls, DLM_RS_DONE);
error = dlm_recover_done_wait(ls);
if (error) {
log_error(ls, "recover_done_wait failed %d", error);
log_debug(ls, "recover_done_wait failed %d", error);
goto fail;
}

dlm_clear_members_gone(ls);

error = enable_locking(ls, rv->seq);
if (error) {
log_error(ls, "enable_locking failed %d", error);
log_debug(ls, "enable_locking failed %d", error);
goto fail;
}

error = dlm_process_requestqueue(ls);
if (error) {
log_error(ls, "process_requestqueue failed %d", error);
log_debug(ls, "process_requestqueue failed %d", error);
goto fail;
}

error = dlm_recover_waiters_post(ls);
if (error) {
log_error(ls, "recover_waiters_post failed %d", error);
log_debug(ls, "recover_waiters_post failed %d", error);
goto fail;
}

Expand Down

0 comments on commit 8ec6886

Please sign in to comment.