Skip to content

Commit

Permalink
workqueue: correct handling of the pool spin_lock
Browse files Browse the repository at this point in the history
When we fail to mutex_trylock(), we release the pool spin_lock and do
mutex_lock(). After that, we should regrab the pool spin_lock, but,
regrabbing is missed in current code. So correct it.

Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Joonsoo Kim authored and Tejun Heo committed May 14, 2013
1 parent d325185 commit 8f174b1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions kernel/workqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -2059,6 +2059,7 @@ static bool manage_workers(struct worker *worker)
if (unlikely(!mutex_trylock(&pool->manager_mutex))) {
spin_unlock_irq(&pool->lock);
mutex_lock(&pool->manager_mutex);
spin_lock_irq(&pool->lock);
ret = true;
}

Expand Down

0 comments on commit 8f174b1

Please sign in to comment.