Skip to content

Commit

Permalink
mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback …
Browse files Browse the repository at this point in the history
…handler

The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
  • Loading branch information
Axel Lin authored and Liam Girdwood committed Aug 11, 2010
1 parent 1bddc2f commit 8f1f151
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/mfd/max8998.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
int ret = 0;

max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
if (max8998 == NULL) {
kfree(i2c);
if (max8998 == NULL)
return -ENOMEM;
}

i2c_set_clientdata(i2c, max8998);
max8998->dev = &i2c->dev;
Expand Down

0 comments on commit 8f1f151

Please sign in to comment.