Skip to content

Commit

Permalink
OMAPDSS: VENC: Replace dssdev->manager with dssdev->output->manager r…
Browse files Browse the repository at this point in the history
…eferences

With addition of output entities, a device connects to an output, and an output
connects to overlay manager. Replace the dssdev->manager references with
dssdev->output->manager to access the manager correctly.

When enabling the VENC output, check whether the output entity connected to
display is not NULL.

Signed-off-by: Archit Taneja <archit@ti.com>
  • Loading branch information
Archit Taneja authored and Tomi Valkeinen committed Sep 26, 2012
1 parent 1db39c0 commit 8f1f736
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions drivers/video/omap2/dss/venc.c
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ static const struct venc_config *venc_timings_to_config(

static int venc_power_on(struct omap_dss_device *dssdev)
{
struct omap_overlay_manager *mgr = dssdev->output->manager;
u32 l;
int r;

Expand All @@ -454,13 +455,13 @@ static int venc_power_on(struct omap_dss_device *dssdev)

venc_write_reg(VENC_OUTPUT_CONTROL, l);

dss_mgr_set_timings(dssdev->manager, &venc.timings);
dss_mgr_set_timings(mgr, &venc.timings);

r = regulator_enable(venc.vdda_dac_reg);
if (r)
goto err1;

r = dss_mgr_enable(dssdev->manager);
r = dss_mgr_enable(mgr);
if (r)
goto err2;

Expand All @@ -479,10 +480,12 @@ static int venc_power_on(struct omap_dss_device *dssdev)

static void venc_power_off(struct omap_dss_device *dssdev)
{
struct omap_overlay_manager *mgr = dssdev->output->manager;

venc_write_reg(VENC_OUTPUT_CONTROL, 0);
dss_set_dac_pwrdn_bgz(0);

dss_mgr_disable(dssdev->manager);
dss_mgr_disable(mgr);

regulator_disable(venc.vdda_dac_reg);

Expand All @@ -497,14 +500,15 @@ unsigned long venc_get_pixel_clock(void)

int omapdss_venc_display_enable(struct omap_dss_device *dssdev)
{
struct omap_dss_output *out = dssdev->output;
int r;

DSSDBG("venc_display_enable\n");

mutex_lock(&venc.venc_lock);

if (dssdev->manager == NULL) {
DSSERR("Failed to enable display: no manager\n");
if (out == NULL || out->manager == NULL) {
DSSERR("Failed to enable display: no output/manager\n");
r = -ENODEV;
goto err0;
}
Expand Down

0 comments on commit 8f1f736

Please sign in to comment.