Skip to content

Commit

Permalink
rtlwifi: Remove extraneous value return
Browse files Browse the repository at this point in the history
In usb.c, routine _rtl_usb_init_sw() always returns 0, and rtl_usb_probe()
never checks the returned value. Thus we can change _rtl_usb_init_sw() to
a void routine. In addition, remove the underscore at the beginning of the
name of the routine.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Larry Finger authored and John W. Linville committed Mar 5, 2012
1 parent 48de1a1 commit 8f526ab
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/net/wireless/rtlwifi/usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ static int _rtl_usb_init(struct ieee80211_hw *hw)
return err;
}

static int _rtl_usb_init_sw(struct ieee80211_hw *hw)
static void rtl_usb_init_sw(struct ieee80211_hw *hw)
{
struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
Expand Down Expand Up @@ -397,7 +397,6 @@ static int _rtl_usb_init_sw(struct ieee80211_hw *hw)
/* HIMR_EX - turn all on */
rtlusb->irq_mask[1] = 0xFFFFFFFF;
rtlusb->disableHWSM = true;
return 0;
}

#define __RADIO_TAP_SIZE_RSV 32
Expand Down Expand Up @@ -983,7 +982,7 @@ int __devinit rtl_usb_probe(struct usb_interface *intf,
err = _rtl_usb_init(hw);
if (err)
goto error_out;
err = _rtl_usb_init_sw(hw);
rtl_usb_init_sw(hw);
/* Init mac80211 sw */
err = rtl_init_core(hw);
if (err) {
Expand Down

0 comments on commit 8f526ab

Please sign in to comment.