Skip to content

Commit

Permalink
[PATCH] change io_cancel return code for no cancel case
Browse files Browse the repository at this point in the history
Note that other than few exceptions, most of the current filesystem and/or
drivers do not have aio cancel specifically defined (kiob->ki_cancel field
is mostly NULL).  However, sys_io_cancel system call universally sets
return code to -EAGAIN.  This gives applications a wrong impression that
this call is implemented but just never works.  We have customer inquires
about this issue.

Changed by Benjamin LaHaise to EINVAL instead of ENOSYS

Signed-off-by: S. Wendy Cheng <wcheng@redhat.com>
Acked-by: Benjamin LaHaise <bcrl@kvack.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Wendy Cheng authored and Linus Torvalds committed Sep 9, 2005
1 parent 6f51916 commit 8f58202
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/aio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1673,7 +1673,7 @@ asmlinkage long sys_io_cancel(aio_context_t ctx_id, struct iocb __user *iocb,
ret = -EFAULT;
}
} else
printk(KERN_DEBUG "iocb has no cancel operation\n");
ret = -EINVAL;

put_ioctx(ctx);

Expand Down

0 comments on commit 8f58202

Please sign in to comment.