Skip to content

Commit

Permalink
Staging: iio: iio_simple_dummy: Remove explicit NULL comparison
Browse files Browse the repository at this point in the history
This patch removes explicit NULL comparison and writes it in its
simpler form. Done with coccinelle:

@replace_rule@
expression e;
@@

-e == NULL
+ !e

Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Cristina Opriceana authored and Greg Kroah-Hartman committed Apr 1, 2015
1 parent 025c7da commit 8f94c31
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/staging/iio/iio_simple_dummy.c
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ static int iio_dummy_probe(int index)
* for chip specific state information.
*/
indio_dev = iio_device_alloc(sizeof(*st));
if (indio_dev == NULL) {
if (!indio_dev) {
ret = -ENOMEM;
goto error_ret;
}
Expand Down
6 changes: 3 additions & 3 deletions drivers/staging/iio/iio_simple_dummy_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ static irqreturn_t iio_simple_dummy_trigger_h(int irq, void *p)
u16 *data;

data = kmalloc(indio_dev->scan_bytes, GFP_KERNEL);
if (data == NULL)
if (!data)
goto done;

if (!bitmap_empty(indio_dev->active_scan_mask, indio_dev->masklength)) {
Expand Down Expand Up @@ -122,7 +122,7 @@ int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev)

/* Allocate a buffer to use - here a kfifo */
buffer = iio_kfifo_allocate();
if (buffer == NULL) {
if (!buffer) {
ret = -ENOMEM;
goto error_ret;
}
Expand Down Expand Up @@ -161,7 +161,7 @@ int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev)
"iio_simple_dummy_consumer%d",
indio_dev->id);

if (indio_dev->pollfunc == NULL) {
if (!indio_dev->pollfunc) {
ret = -ENOMEM;
goto error_free_buffer;
}
Expand Down

0 comments on commit 8f94c31

Please sign in to comment.