Skip to content

Commit

Permalink
locks: allow lockd to process blocked locks during grace period
Browse files Browse the repository at this point in the history
The check here is currently harmless but unnecessary, since, as the
comment notes, there aren't any blocked-lock callbacks to process
during the grace period anyway.

And eventually we want to allow multiple grace periods that come and go
for different filesystems over the course of the lifetime of lockd, at
which point this check is just going to get in the way.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
J. Bruce Fields committed Sep 29, 2008
1 parent 54a66e5 commit 8fafa90
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions fs/lockd/svc.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,15 +158,9 @@ lockd(void *vrqstp)
continue;
}

/*
* Retry any blocked locks that have been notified by
* the VFS. Don't do this during grace period.
* (Theoretically, there shouldn't even be blocked locks
* during grace period).
*/
if (!nlmsvc_grace_period) {
timeout = nlmsvc_retry_blocked();
} else if (time_before(grace_period_expire, jiffies))
timeout = nlmsvc_retry_blocked();

if (time_before(grace_period_expire, jiffies))
clear_grace_period();

/*
Expand Down

0 comments on commit 8fafa90

Please sign in to comment.