Skip to content

Commit

Permalink
ARM: S3C24XX: serial: Fix section mismatch warnings
Browse files Browse the repository at this point in the history
During kernel build process, the following warning was found:

WARNING: drivers/serial/built-in.o(.data+0x304): Section mismatch in reference from
the variable s3c2440_serial_drv to the function .devexit.text:s3c24xx_serial_remove()
The variable s3c2440_serial_drv references the function __devexit s3c24xx_serial_remove()
If the reference is valid then annotate the variable with
__exit* (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,

The same warning happened for s3c241x platform. We rename variables to avoid
these warnings. These changes also apply to s3c2400 & s3c24a0 for consistency.

Signed-off-by: Ramax Lo <ramaxlo@gmail.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
  • Loading branch information
Ramax Lo authored and Ben Dooks committed Jul 30, 2009
1 parent 165f5f6 commit 8fe70a5
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 20 deletions.
8 changes: 4 additions & 4 deletions drivers/serial/s3c2400.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ static int s3c2400_serial_probe(struct platform_device *dev)
return s3c24xx_serial_probe(dev, &s3c2400_uart_inf);
}

static struct platform_driver s3c2400_serial_drv = {
static struct platform_driver s3c2400_serial_driver = {
.probe = s3c2400_serial_probe,
.remove = __devexit_p(s3c24xx_serial_remove),
.driver = {
Expand All @@ -85,16 +85,16 @@ static struct platform_driver s3c2400_serial_drv = {
},
};

s3c24xx_console_init(&s3c2400_serial_drv, &s3c2400_uart_inf);
s3c24xx_console_init(&s3c2400_serial_driver, &s3c2400_uart_inf);

static inline int s3c2400_serial_init(void)
{
return s3c24xx_serial_init(&s3c2400_serial_drv, &s3c2400_uart_inf);
return s3c24xx_serial_init(&s3c2400_serial_driver, &s3c2400_uart_inf);
}

static inline void s3c2400_serial_exit(void)
{
platform_driver_unregister(&s3c2400_serial_drv);
platform_driver_unregister(&s3c2400_serial_driver);
}

module_init(s3c2400_serial_init);
Expand Down
8 changes: 4 additions & 4 deletions drivers/serial/s3c2410.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ static int s3c2410_serial_probe(struct platform_device *dev)
return s3c24xx_serial_probe(dev, &s3c2410_uart_inf);
}

static struct platform_driver s3c2410_serial_drv = {
static struct platform_driver s3c2410_serial_driver = {
.probe = s3c2410_serial_probe,
.remove = __devexit_p(s3c24xx_serial_remove),
.driver = {
Expand All @@ -97,16 +97,16 @@ static struct platform_driver s3c2410_serial_drv = {
},
};

s3c24xx_console_init(&s3c2410_serial_drv, &s3c2410_uart_inf);
s3c24xx_console_init(&s3c2410_serial_driver, &s3c2410_uart_inf);

static int __init s3c2410_serial_init(void)
{
return s3c24xx_serial_init(&s3c2410_serial_drv, &s3c2410_uart_inf);
return s3c24xx_serial_init(&s3c2410_serial_driver, &s3c2410_uart_inf);
}

static void __exit s3c2410_serial_exit(void)
{
platform_driver_unregister(&s3c2410_serial_drv);
platform_driver_unregister(&s3c2410_serial_driver);
}

module_init(s3c2410_serial_init);
Expand Down
8 changes: 4 additions & 4 deletions drivers/serial/s3c2412.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ static int s3c2412_serial_probe(struct platform_device *dev)
return s3c24xx_serial_probe(dev, &s3c2412_uart_inf);
}

static struct platform_driver s3c2412_serial_drv = {
static struct platform_driver s3c2412_serial_driver = {
.probe = s3c2412_serial_probe,
.remove = __devexit_p(s3c24xx_serial_remove),
.driver = {
Expand All @@ -130,16 +130,16 @@ static struct platform_driver s3c2412_serial_drv = {
},
};

s3c24xx_console_init(&s3c2412_serial_drv, &s3c2412_uart_inf);
s3c24xx_console_init(&s3c2412_serial_driver, &s3c2412_uart_inf);

static inline int s3c2412_serial_init(void)
{
return s3c24xx_serial_init(&s3c2412_serial_drv, &s3c2412_uart_inf);
return s3c24xx_serial_init(&s3c2412_serial_driver, &s3c2412_uart_inf);
}

static inline void s3c2412_serial_exit(void)
{
platform_driver_unregister(&s3c2412_serial_drv);
platform_driver_unregister(&s3c2412_serial_driver);
}

module_init(s3c2412_serial_init);
Expand Down
8 changes: 4 additions & 4 deletions drivers/serial/s3c2440.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ static int s3c2440_serial_probe(struct platform_device *dev)
return s3c24xx_serial_probe(dev, &s3c2440_uart_inf);
}

static struct platform_driver s3c2440_serial_drv = {
static struct platform_driver s3c2440_serial_driver = {
.probe = s3c2440_serial_probe,
.remove = __devexit_p(s3c24xx_serial_remove),
.driver = {
Expand All @@ -160,16 +160,16 @@ static struct platform_driver s3c2440_serial_drv = {
},
};

s3c24xx_console_init(&s3c2440_serial_drv, &s3c2440_uart_inf);
s3c24xx_console_init(&s3c2440_serial_driver, &s3c2440_uart_inf);

static int __init s3c2440_serial_init(void)
{
return s3c24xx_serial_init(&s3c2440_serial_drv, &s3c2440_uart_inf);
return s3c24xx_serial_init(&s3c2440_serial_driver, &s3c2440_uart_inf);
}

static void __exit s3c2440_serial_exit(void)
{
platform_driver_unregister(&s3c2440_serial_drv);
platform_driver_unregister(&s3c2440_serial_driver);
}

module_init(s3c2440_serial_init);
Expand Down
8 changes: 4 additions & 4 deletions drivers/serial/s3c24a0.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ static int s3c24a0_serial_probe(struct platform_device *dev)
return s3c24xx_serial_probe(dev, &s3c24a0_uart_inf);
}

static struct platform_driver s3c24a0_serial_drv = {
static struct platform_driver s3c24a0_serial_driver = {
.probe = s3c24a0_serial_probe,
.remove = __devexit_p(s3c24xx_serial_remove),
.driver = {
Expand All @@ -101,16 +101,16 @@ static struct platform_driver s3c24a0_serial_drv = {
},
};

s3c24xx_console_init(&s3c24a0_serial_drv, &s3c24a0_uart_inf);
s3c24xx_console_init(&s3c24a0_serial_driver, &s3c24a0_uart_inf);

static int __init s3c24a0_serial_init(void)
{
return s3c24xx_serial_init(&s3c24a0_serial_drv, &s3c24a0_uart_inf);
return s3c24xx_serial_init(&s3c24a0_serial_driver, &s3c24a0_uart_inf);
}

static void __exit s3c24a0_serial_exit(void)
{
platform_driver_unregister(&s3c24a0_serial_drv);
platform_driver_unregister(&s3c24a0_serial_driver);
}

module_init(s3c24a0_serial_init);
Expand Down

0 comments on commit 8fe70a5

Please sign in to comment.