Skip to content

Commit

Permalink
perf tools: Fix missing symtabs printouts
Browse files Browse the repository at this point in the history
Fix:

  util/map.c: In function ‘map__find_symbol’:
  util/map.c:97: error: field precision should have type ‘int’, but argument 3 has type ‘size_t’

Also clean up some line wrap damage - we dont line-wrap printk
messages.

Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256927305-4628-3-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Nov 2, 2009
1 parent d70a540 commit 900b20d
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions tools/perf/util/map.c
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,12 @@ map__find_symbol(struct map *self, u64 ip, symbol_filter_t filter)
const size_t real_len = len - sizeof(DSO__DELETED);

if (len > sizeof(DSO__DELETED) &&
strcmp(name + real_len + 1, DSO__DELETED) == 0)
pr_warning("%.*s was updated, restart the "
"long running apps that use it!\n",
real_len, name);
else
pr_warning("no symbols found in %s, maybe "
"install a debug package?\n", name);
strcmp(name + real_len + 1, DSO__DELETED) == 0) {
pr_warning("%.*s was updated, restart the long running apps that use it!\n",
(int)real_len, name);
} else {
pr_warning("no symbols found in %s, maybe install a debug package?\n", name);
}
return NULL;
}
}
Expand Down

0 comments on commit 900b20d

Please sign in to comment.