Skip to content

Commit

Permalink
sched: handle vruntime 64-bit overflow
Browse files Browse the repository at this point in the history
Handle vruntime overflow by centering the key space around min_vruntime.

( otherwise we could overflow 64-bit vruntime in a few days with SCHED_IDLE
 tasks - or in a few years with nice +19. )

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Mike Galbraith <efault@gmx.de>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Oct 15, 2007
1 parent 94dfb5e commit 9014623
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions kernel/sched_fair.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,18 @@ set_leftmost(struct cfs_rq *cfs_rq, struct rb_node *leftmost)
cfs_rq->rb_leftmost = leftmost;
if (leftmost) {
se = rb_entry(leftmost, struct sched_entity, run_node);
cfs_rq->min_vruntime = max(se->vruntime,
cfs_rq->min_vruntime);
if ((se->vruntime > cfs_rq->min_vruntime) ||
(cfs_rq->min_vruntime > (1ULL << 61) &&
se->vruntime < (1ULL << 50)))
cfs_rq->min_vruntime = se->vruntime;
}
}

s64 entity_key(struct cfs_rq *cfs_rq, struct sched_entity *se)
{
return se->fair_key - cfs_rq->min_vruntime;
}

/*
* Enqueue an entity into the rb-tree:
*/
Expand All @@ -138,7 +145,7 @@ __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
struct rb_node **link = &cfs_rq->tasks_timeline.rb_node;
struct rb_node *parent = NULL;
struct sched_entity *entry;
s64 key = se->fair_key;
s64 key = entity_key(cfs_rq, se);
int leftmost = 1;

/*
Expand All @@ -151,7 +158,7 @@ __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
* We dont care about collisions. Nodes with
* the same key stay together.
*/
if (key - entry->fair_key < 0) {
if (key < entity_key(cfs_rq, entry)) {
link = &parent->rb_left;
} else {
link = &parent->rb_right;
Expand Down

0 comments on commit 9014623

Please sign in to comment.