Skip to content

Commit

Permalink
hwrng: msm - make use of devm_hwrng_register
Browse files Browse the repository at this point in the history
This allows us to get rid of remove() method.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Dmitry Torokhov authored and Herbert Xu committed Mar 16, 2015
1 parent 1e6e38a commit 9052b0d
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions drivers/char/hw_random/msm-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ static int msm_rng_probe(struct platform_device *pdev)
rng->hwrng.cleanup = msm_rng_cleanup,
rng->hwrng.read = msm_rng_read,

ret = hwrng_register(&rng->hwrng);
ret = devm_hwrng_register(&pdev->dev, &rng->hwrng);
if (ret) {
dev_err(&pdev->dev, "failed to register hwrng\n");
return ret;
Expand All @@ -166,14 +166,6 @@ static int msm_rng_probe(struct platform_device *pdev)
return 0;
}

static int msm_rng_remove(struct platform_device *pdev)
{
struct msm_rng *rng = platform_get_drvdata(pdev);

hwrng_unregister(&rng->hwrng);
return 0;
}

static const struct of_device_id msm_rng_of_match[] = {
{ .compatible = "qcom,prng", },
{}
Expand All @@ -182,7 +174,6 @@ MODULE_DEVICE_TABLE(of, msm_rng_of_match);

static struct platform_driver msm_rng_driver = {
.probe = msm_rng_probe,
.remove = msm_rng_remove,
.driver = {
.name = KBUILD_MODNAME,
.of_match_table = of_match_ptr(msm_rng_of_match),
Expand Down

0 comments on commit 9052b0d

Please sign in to comment.