Skip to content

Commit

Permalink
mtd: move mtd_oob_mode_t to shared kernel/user space
Browse files Browse the repository at this point in the history
We will want to use the MTD_OOB_{PLACE,AUTO,RAW} modes in user-space
applications through the introduction of new ioctls, so we should make
this enum a shared type.

This enum is now anonymous.

Artem: tweaked the patch.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
  • Loading branch information
Brian Norris authored and Artem Bityutskiy committed Sep 11, 2011
1 parent c46f648 commit 905c6bc
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 17 deletions.
4 changes: 2 additions & 2 deletions drivers/mtd/onenand/onenand_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ static int onenand_read_oob_nolock(struct mtd_info *mtd, loff_t from,
struct mtd_ecc_stats stats;
int read = 0, thislen, column, oobsize;
size_t len = ops->ooblen;
mtd_oob_mode_t mode = ops->mode;
unsigned int mode = ops->mode;
u_char *buf = ops->oobbuf;
int ret = 0, readcmd;

Expand Down Expand Up @@ -2074,7 +2074,7 @@ static int onenand_write_oob_nolock(struct mtd_info *mtd, loff_t to,
u_char *oobbuf;
size_t len = ops->ooblen;
const u_char *buf = ops->oobbuf;
mtd_oob_mode_t mode = ops->mode;
unsigned int mode = ops->mode;

to += ops->ooboffs;

Expand Down
16 changes: 1 addition & 15 deletions include/linux/mtd/mtd.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,6 @@ struct mtd_erase_region_info {
unsigned long *lockmap; /* If keeping bitmap of locks */
};

/*
* oob operation modes
*
* MTD_OOB_PLACE: oob data are placed at the given offset
* MTD_OOB_AUTO: oob data are automatically placed at the free areas
* which are defined by the ecclayout
* MTD_OOB_RAW: mode to read oob and data without doing ECC checking
*/
typedef enum {
MTD_OOB_PLACE,
MTD_OOB_AUTO,
MTD_OOB_RAW,
} mtd_oob_mode_t;

/**
* struct mtd_oob_ops - oob operation operands
* @mode: operation mode
Expand All @@ -102,7 +88,7 @@ typedef enum {
* OOB area.
*/
struct mtd_oob_ops {
mtd_oob_mode_t mode;
unsigned int mode;
size_t len;
size_t retlen;
size_t ooblen;
Expand Down
15 changes: 15 additions & 0 deletions include/mtd/mtd-abi.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,21 @@ struct mtd_oob_buf64 {
__u64 usr_ptr;
};

/*
* oob operation modes
*
* MTD_OOB_PLACE: oob data are placed at the given offset (default)
* MTD_OOB_AUTO: oob data are automatically placed at the free areas
* which are defined by the internal ecclayout
* MTD_OOB_RAW: mode to read or write oob and data without doing ECC
* checking
*/
enum {
MTD_OOB_PLACE = 0,
MTD_OOB_AUTO = 1,
MTD_OOB_RAW = 2,
};

#define MTD_ABSENT 0
#define MTD_RAM 1
#define MTD_ROM 2
Expand Down

0 comments on commit 905c6bc

Please sign in to comment.