Skip to content

Commit

Permalink
[PATCH] x86-64: Always flush all pages in change_page_attr
Browse files Browse the repository at this point in the history
change_page_attr on x86-64 only flushed the TLB for pages that got
reverted. That's not correct: it has to be flushed in all cases.

This bug was added in some earlier changes.

Just flush all pages for now.

This could be done more efficiently, but for this late in the release
this seem to be the best fix.

Pointed out by Jan Beulich

Signed-off-by: Andi Kleen <ak@suse.de>
  • Loading branch information
Andi Kleen authored and Andi Kleen committed Apr 24, 2007
1 parent 9ce883b commit 90767bd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86_64/mm/pageattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ static void flush_kernel_map(void *arg)
void *adr = page_address(pg);
if (cpu_has_clflush)
cache_flush_page(adr);
__flush_tlb_one(adr);
}
__flush_tlb_all();
}

static inline void flush_map(struct list_head *l)
Expand Down

0 comments on commit 90767bd

Please sign in to comment.