Skip to content

Commit

Permalink
[PATCH] tulip: add return to ULI526X clause in tulip_mdio_write
Browse files Browse the repository at this point in the history
The 'if' clause for ULI526X in tulip_mdio_write allows for
spin_unlock_irqrestore to be called twice for tp->mii_lock.  I believe
this is caused by the unintentional omission of a return at the end
of that clause.  This patch adds that return.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
John W. Linville authored and Jeff Garzik committed May 24, 2005
1 parent 187a1a9 commit 9092f46
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/tulip/media.c
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ void tulip_mdio_write(struct net_device *dev, int phy_id, int location, int val)
break;
}
spin_unlock_irqrestore(&tp->mii_lock, flags);
return;
}

/* Establish sync by sending 32 logic ones. */
Expand Down

0 comments on commit 9092f46

Please sign in to comment.