Skip to content

Commit

Permalink
iwlwifi: fix searching for best rate in new search column
Browse files Browse the repository at this point in the history
This patch fixes a bug in Rate Scaling. When moving from SISO to MIMO we
need to choose the lowest higher rate, instead of choosing the highest in MIMO.
No doing this can lead to a high packet loss in the highest rate in MIMO,
leading not to move MIMO although lower in MIMO could give a better TPT.

Signed-off-by: Guy Cohen <guy.cohen@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Guy Cohen authored and John W. Linville committed Sep 11, 2008
1 parent 12e5e22 commit 90d7795
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/wireless/iwlwifi/iwl-agn-rs.c
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ static int rs_collect_tx_data(struct iwl_rate_scale_data *windows,
/* Shift bitmap by one frame (throw away oldest history),
* OR in "1", and increment "success" if this
* frame was successful. */
window->data <<= 1;;
window->data <<= 1;
if (successes > 0) {
window->success_counter++;
window->data |= 0x1;
Expand Down Expand Up @@ -1128,6 +1128,7 @@ static s32 rs_get_best_rate(struct iwl_priv *priv,

/* Higher rate not available, use the original */
} else {
new_rate = rate;
break;
}
}
Expand Down

0 comments on commit 90d7795

Please sign in to comment.