Skip to content

Commit

Permalink
drivers/misc: Move misplaced pci_dev_put's
Browse files Browse the repository at this point in the history
Move pci_dev_put outside the loops in which it occurs.  Within the loop,
pci_dev_put is done implicitly by pci_get_device.

The problem was detected using the following semantic patch, and corrected
by hand.

@@
expression dev;
expression E;
@@

- pci_dev_put(dev)
   ... when != dev = E
- pci_get_device(...,dev)

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Julia Lawall authored and Linus Torvalds committed Nov 15, 2007
1 parent e62aa04 commit 90d8dab
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions drivers/misc/ioc4.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,11 @@ ioc4_variant(struct ioc4_driver_data *idd)
idd->idd_pdev->bus->number == pdev->bus->number &&
3 == PCI_SLOT(pdev->devfn))
found = 1;
pci_dev_put(pdev);
} while (pdev && !found);
if (NULL != pdev)
if (NULL != pdev) {
pci_dev_put(pdev);
return IOC4_VARIANT_IO9;
}

/* IO10: Look for a Vitesse VSC 7174 at the same bus and slot 3. */
pdev = NULL;
Expand All @@ -258,10 +259,11 @@ ioc4_variant(struct ioc4_driver_data *idd)
idd->idd_pdev->bus->number == pdev->bus->number &&
3 == PCI_SLOT(pdev->devfn))
found = 1;
pci_dev_put(pdev);
} while (pdev && !found);
if (NULL != pdev)
if (NULL != pdev) {
pci_dev_put(pdev);
return IOC4_VARIANT_IO10;
}

/* PCI-RT: No SCSI/SATA controller will be present */
return IOC4_VARIANT_PCI_RT;
Expand Down

0 comments on commit 90d8dab

Please sign in to comment.