Skip to content

Commit

Permalink
hwmon: (jc42) Allow negative hysteresis temperatures
Browse files Browse the repository at this point in the history
The driver supports negative high and critical limits, it can return
negative hysteresis values, so there is no good reason to not let the
user write negative hysteresis values.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Jean Delvare authored and Guenter Roeck committed Jan 26, 2015
1 parent 2c3b118 commit 9130880
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/hwmon/jc42.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,15 +304,16 @@ static ssize_t set_temp_crit_hyst(struct device *dev,
const char *buf, size_t count)
{
struct jc42_data *data = dev_get_drvdata(dev);
unsigned long val;
long val;
int diff, hyst;
int err;
int ret = count;

if (kstrtoul(buf, 10, &val) < 0)
if (kstrtol(buf, 10, &val) < 0)
return -EINVAL;

val = clamp_val(val, 0, JC42_TEMP_MAX);
val = clamp_val(val, (data->extended ? JC42_TEMP_MIN_EXTENDED :
JC42_TEMP_MIN) - 6000, JC42_TEMP_MAX);
diff = jc42_temp_from_reg(data->temp[t_crit]) - val;

hyst = 0;
Expand Down

0 comments on commit 9130880

Please sign in to comment.