Skip to content

Commit

Permalink
param: make param sections const.
Browse files Browse the repository at this point in the history
Since this section can be read-only (they're in .rodata), they should
always have been const.  Minor flow-through various functions.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Tested-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
  • Loading branch information
Rusty Russell committed Aug 11, 2010
1 parent a105432 commit 914dcaa
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion include/linux/moduleparam.h
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ __check_old_set_param(int (*oldset)(const char *, struct kernel_param *))
/* Called on module insert or kernel boot */
extern int parse_args(const char *name,
char *args,
struct kernel_param *params,
const struct kernel_param *params,
unsigned num,
int (*unknown)(char *param, char *val));

Expand Down
8 changes: 4 additions & 4 deletions init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,11 @@ static char * argv_init[MAX_INIT_ARGS+2] = { "init", NULL, };
char * envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
static const char *panic_later, *panic_param;

extern struct obs_kernel_param __setup_start[], __setup_end[];
extern const struct obs_kernel_param __setup_start[], __setup_end[];

static int __init obsolete_checksetup(char *line)
{
struct obs_kernel_param *p;
const struct obs_kernel_param *p;
int had_early_param = 0;

p = __setup_start;
Expand Down Expand Up @@ -458,7 +458,7 @@ static noinline void __init_refok rest_init(void)
/* Check for early params. */
static int __init do_early_param(char *param, char *val)
{
struct obs_kernel_param *p;
const struct obs_kernel_param *p;

for (p = __setup_start; p < __setup_end; p++) {
if ((p->early && strcmp(param, p->str) == 0) ||
Expand Down Expand Up @@ -536,7 +536,7 @@ static void __init mm_init(void)
asmlinkage void __init start_kernel(void)
{
char * command_line;
extern struct kernel_param __start___param[], __stop___param[];
extern const struct kernel_param __start___param[], __stop___param[];

smp_setup_processor_id();

Expand Down
4 changes: 2 additions & 2 deletions kernel/params.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ static inline int parameq(const char *input, const char *paramname)

static int parse_one(char *param,
char *val,
struct kernel_param *params,
const struct kernel_param *params,
unsigned num_params,
int (*handle_unknown)(char *param, char *val))
{
Expand Down Expand Up @@ -170,7 +170,7 @@ static char *next_arg(char *args, char **param, char **val)
/* Args looks like "foo=bar,bar2 baz=fuz wiz". */
int parse_args(const char *name,
char *args,
struct kernel_param *params,
const struct kernel_param *params,
unsigned num,
int (*unknown)(char *param, char *val))
{
Expand Down

0 comments on commit 914dcaa

Please sign in to comment.