Skip to content

Commit

Permalink
tipc: Minor optimization of broadcast link transmit queue statistic
Browse files Browse the repository at this point in the history
The two broadcast link statistics fields that are used to derive the
average length of that link's transmit queue are now updated only after
a successful attempt to send a broadcast message, since there is no need
to update these values when an unsuccessful send attempt leaves the
queue unchanged.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
  • Loading branch information
Allan Stephens authored and Paul Gortmaker committed Dec 27, 2011
1 parent 2b78f9a commit 9157baf
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions net/tipc/bcast.c
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,11 @@ int tipc_bclink_send_msg(struct sk_buff *buf)
}

res = tipc_link_send_buf(bcl, buf);
if (likely(res > 0))
if (likely(res >= 0)) {
bclink_set_last_sent();

bcl->stats.queue_sz_counts++;
bcl->stats.accu_queue_sz += bcl->out_queue_size;
bcl->stats.queue_sz_counts++;
bcl->stats.accu_queue_sz += bcl->out_queue_size;
}
exit:
spin_unlock_bh(&bc_lock);
return res;
Expand Down

0 comments on commit 9157baf

Please sign in to comment.