Skip to content

Commit

Permalink
staging: brcm80211: removed unused softmac transmit power variables
Browse files Browse the repository at this point in the history
Struct member variables were only set to '0'. As a result, function
brcms_c_local_constraint_qdbm() always returned BRCMS_TXPWR_MAX and
thus could be removed.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Roland Vossen authored and Greg Kroah-Hartman committed Sep 12, 2011
1 parent 4ea50d5 commit 91591c0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 39 deletions.
34 changes: 2 additions & 32 deletions drivers/staging/brcm80211/brcmsmac/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3275,44 +3275,14 @@ static brcms_b_init(struct brcms_hardware *wlc_hw, u16 chanspec,
brcms_b_clkctl_clk(wlc_hw, CLK_DYNAMIC);
}

static u8 brcms_c_local_constraint_qdbm(struct brcms_c_info *wlc)
{
u8 local;
s16 local_max;

local = BRCMS_TXPWR_MAX;
if (wlc->pub->associated &&
(brcmu_chspec_ctlchan(wlc->chanspec) ==
brcmu_chspec_ctlchan(wlc->home_chanspec))) {

/* get the local power constraint if we are on the AP's
* channel [802.11h, 7.3.2.13]
*/
/* Clamp the value between 0 and BRCMS_TXPWR_MAX w/o
* overflowing the target */
local_max =
(wlc->txpwr_local_max -
wlc->txpwr_local_constraint) * BRCMS_TXPWR_DB_FACTOR;
if (local_max > 0 && local_max < BRCMS_TXPWR_MAX)
return (u8) local_max;
if (local_max < 0)
return 0;
}

return local;
}

static void brcms_c_set_phy_chanspec(struct brcms_c_info *wlc,
u16 chanspec)
{
/* Save our copy of the chanspec */
wlc->chanspec = chanspec;

/* Set the chanspec and power limits for this locale after computing
* any 11h local tx power constraints.
*/
brcms_c_channel_set_chanspec(wlc->cmi, chanspec,
brcms_c_local_constraint_qdbm(wlc));
/* Set the chanspec and power limits for this locale */
brcms_c_channel_set_chanspec(wlc->cmi, chanspec, BRCMS_TXPWR_MAX);

if (wlc->stf->ss_algosel_auto)
brcms_c_stf_ss_algo_channel_get(wlc, &wlc->stf->ss_algo_channel,
Expand Down
7 changes: 0 additions & 7 deletions drivers/staging/brcm80211/brcmsmac/main.h
Original file line number Diff line number Diff line change
Expand Up @@ -467,8 +467,6 @@ struct brcms_txq_info {
* war16165: PCI slow clock 16165 war flag.
* txpend16165war: PCI slow clock 16165 war flag.
* qvalid: DirFrmQValid and BcMcFrmQValid.
* txpwr_local_max: regulatory local txpwr max.
* txpwr_local_constraint: local power contraint in dB.
* ampdu: ampdu module handler.
* asi: antsel module handler.
* cmi: channel manager module handler.
Expand Down Expand Up @@ -574,11 +572,6 @@ struct brcms_c_info {
/* packet queue */
uint qvalid;

/* Regulatory power limits */
s8 txpwr_local_max;
u8 txpwr_local_constraint;


struct ampdu_info *ampdu;
struct antsel_info *asi;
struct brcms_cm_info *cmi;
Expand Down

0 comments on commit 91591c0

Please sign in to comment.