Skip to content

Commit

Permalink
Input: atmel_mxt_ts - print less overhead when dumping objects
Browse files Browse the repository at this point in the history
Conserve limited (PAGE_SIZE) sysfs output buffer space by only showing
readable objects and not printing the object's index, which is not useful
to userspace.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
  • Loading branch information
Daniel Kurtz authored and Henrik Rydberg committed Jun 29, 2012
1 parent 43a91d5 commit 9163095
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/input/touchscreen/atmel_mxt_ts.c
Original file line number Diff line number Diff line change
Expand Up @@ -897,15 +897,11 @@ static ssize_t mxt_object_show(struct device *dev,
for (i = 0; i < data->info.object_num; i++) {
object = data->object_table + i;

count += scnprintf(buf + count, PAGE_SIZE - count,
"Object[%d] (Type %d)\n",
i + 1, object->type);

if (!mxt_object_readable(object->type)) {
count += scnprintf(buf + count, PAGE_SIZE - count,
"\n");
if (!mxt_object_readable(object->type))
continue;
}

count += scnprintf(buf + count, PAGE_SIZE - count,
"T%u:\n", object->type);

error = __mxt_read_reg(data->client, object->start_address,
object->size + 1, obuf);
Expand Down

0 comments on commit 9163095

Please sign in to comment.