Skip to content

Commit

Permalink
sh: Kill off unused flush_icache_user_range().
Browse files Browse the repository at this point in the history
We use flush_cache_page() outright in copy_to_user_page(), and nothing
else needs it, so just kill it off. SH-5 still defines its own version,
but that too will go away in the same fashion once it converts over.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
Paul Mundt committed Aug 15, 2009
1 parent 7fbb2d3 commit 916e978
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 24 deletions.
1 change: 0 additions & 1 deletion arch/sh/include/asm/cacheflush.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#define flush_icache_range(start, end) do { } while (0)
#define flush_icache_page(vma,pg) do { } while (0)
#define flush_cache_sigtramp(vaddr) do { } while (0)
#define flush_icache_user_range(vma,pg,adr,len) do { } while (0)
#define __flush_wback_region(start, size) do { (void)(start); } while (0)
#define __flush_purge_region(start, size) do { (void)(start); } while (0)
#define __flush_invalidate_region(start, size) do { (void)(start); } while (0)
Expand Down
1 change: 0 additions & 1 deletion arch/sh/include/cpu-common/cpu/cacheflush.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#define flush_dcache_page(page) do { } while (0)
#define flush_icache_range(start, end) do { } while (0)
#define flush_icache_page(vma,pg) do { } while (0)
#define flush_icache_user_range(vma,pg,adr,len) do { } while (0)
#define flush_cache_sigtramp(vaddr) do { } while (0)

#endif /* __ASM_CPU_SH2_CACHEFLUSH_H */
1 change: 0 additions & 1 deletion arch/sh/include/cpu-sh2a/cpu/cacheflush.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#define flush_dcache_page(page) do { } while (0)
void flush_icache_range(unsigned long start, unsigned long end);
#define flush_icache_page(vma,pg) do { } while (0)
#define flush_icache_user_range(vma,pg,adr,len) do { } while (0)
#define flush_cache_sigtramp(vaddr) do { } while (0)

#endif /* __ASM_CPU_SH2A_CACHEFLUSH_H */
1 change: 0 additions & 1 deletion arch/sh/include/cpu-sh3/cpu/cacheflush.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ void flush_icache_page(struct vm_area_struct *vma, struct page *page);

/* SH3 has unified cache so no special action needed here */
#define flush_cache_sigtramp(vaddr) do { } while (0)
#define flush_icache_user_range(vma,pg,adr,len) do { } while (0)

#else
#include <cpu-common/cpu/cacheflush.h>
Expand Down
2 changes: 0 additions & 2 deletions arch/sh/include/cpu-sh4/cpu/cacheflush.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ void flush_cache_page(struct vm_area_struct *vma, unsigned long addr,
unsigned long pfn);
void flush_dcache_page(struct page *pg);
void flush_icache_range(unsigned long start, unsigned long end);
void flush_icache_user_range(struct vm_area_struct *vma, struct page *page,
unsigned long addr, int len);

#define flush_icache_page(vma,pg) do { } while (0)

Expand Down
3 changes: 0 additions & 3 deletions arch/sh/include/cpu-sh5/cpu/cacheflush.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ extern void flush_cache_range(struct vm_area_struct *vma, unsigned long start,
extern void flush_cache_page(struct vm_area_struct *vma, unsigned long addr, unsigned long pfn);
extern void flush_dcache_page(struct page *pg);
extern void flush_icache_range(unsigned long start, unsigned long end);
extern void flush_icache_user_range(struct vm_area_struct *vma,
struct page *page, unsigned long addr,
int len);

#define flush_cache_dup_mm(mm) flush_cache_mm(mm)
#define flush_icache_page(vma, page) do { } while (0)
Expand Down
14 changes: 0 additions & 14 deletions arch/sh/mm/cache-sh4.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,20 +401,6 @@ void flush_cache_range(struct vm_area_struct *vma, unsigned long start,
}
}

/*
* flush_icache_user_range
* @vma: VMA of the process
* @page: page
* @addr: U0 address
* @len: length of the range (< page size)
*/
void flush_icache_user_range(struct vm_area_struct *vma,
struct page *page, unsigned long addr, int len)
{
flush_cache_page(vma, addr, page_to_pfn(page));
mb();
}

/**
* __flush_cache_4096
*
Expand Down
2 changes: 1 addition & 1 deletion arch/sh/mm/cache-sh5.c
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
* range following a poke into the program text through the ptrace() call
* from another process (e.g. for BRK instruction insertion).
*/
void flush_icache_user_range(struct vm_area_struct *vma,
static void flush_icache_user_range(struct vm_area_struct *vma,
struct page *page, unsigned long addr, int len)
{

Expand Down

0 comments on commit 916e978

Please sign in to comment.