Skip to content

Commit

Permalink
ext4: fix journal ref count in move_extent_par_page
Browse files Browse the repository at this point in the history
move_extent_par_page calls a_ops->write_begin() to increase journal
handler's reference count. However, if either mext_replace_branches()
or ext4_get_block fails, the increased reference count isn't
decreased. This will cause a later attempt to umount of the fs to hang
forever. The patch addresses the issue by calling ext4_journal_stop()
if page is not NULL (which means a_ops->write_end() isn't invoked).

Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Peng Tao authored and Theodore Ts'o committed Aug 11, 2009
1 parent b1f485f commit 91cc219
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/ext4/move_extent.c
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,7 @@ move_extent_par_page(struct file *o_filp, struct inode *donor_inode,
if (PageLocked(page))
unlock_page(page);
page_cache_release(page);
ext4_journal_stop(handle);
}
out2:
ext4_journal_stop(handle);
Expand Down

0 comments on commit 91cc219

Please sign in to comment.