Skip to content

Commit

Permalink
net: USB: Deletion of unnecessary checks before the function call "kf…
Browse files Browse the repository at this point in the history
…ree"

The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Markus Elfring authored and David S. Miller committed Nov 21, 2014
1 parent 38a90e7 commit 91ecee6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions drivers/net/usb/asix_devices.c
Original file line number Diff line number Diff line change
Expand Up @@ -487,8 +487,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)

static void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
{
if (dev->driver_priv)
kfree(dev->driver_priv);
kfree(dev->driver_priv);
}

static const struct ethtool_ops ax88178_ethtool_ops = {
Expand Down
3 changes: 1 addition & 2 deletions drivers/net/usb/hso.c
Original file line number Diff line number Diff line change
Expand Up @@ -2746,8 +2746,7 @@ struct hso_device *hso_create_mux_serial_device(struct usb_interface *interface,
tty_unregister_device(tty_drv, serial->minor);
kfree(serial);
}
if (hso_dev)
kfree(hso_dev);
kfree(hso_dev);
return NULL;

}
Expand Down

0 comments on commit 91ecee6

Please sign in to comment.