Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 80594
b: refs/heads/master
c: 072d0bb
h: refs/heads/master
v: v3
  • Loading branch information
FUJITA Tomonori authored and James Bottomley committed Jan 30, 2008
1 parent 8ff5b29 commit 9207230
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3de9f944797177e405dcab05f12560a497c019bb
refs/heads/master: 072d0bb3ce3507ac6e101ca8ce0b94c5777c62ed
21 changes: 10 additions & 11 deletions trunk/drivers/scsi/scsi_debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -594,18 +594,18 @@ static int fill_from_dev_buffer(struct scsi_cmnd * scp, unsigned char * arr,
int k, req_len, act_len, len, active;
void * kaddr;
void * kaddr_off;
struct scatterlist * sg;
struct scatterlist *sg;
struct scsi_data_buffer *sdb = scsi_in(scp);

if (0 == scsi_bufflen(scp))
if (!sdb->length)
return 0;
if (NULL == scsi_sglist(scp))
if (!sdb->table.sgl)
return (DID_ERROR << 16);
if (! ((scp->sc_data_direction == DMA_BIDIRECTIONAL) ||
(scp->sc_data_direction == DMA_FROM_DEVICE)))
if (!(scsi_bidi_cmnd(scp) || scp->sc_data_direction == DMA_FROM_DEVICE))
return (DID_ERROR << 16);
active = 1;
req_len = act_len = 0;
scsi_for_each_sg(scp, sg, scsi_sg_count(scp), k) {
for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) {
if (active) {
kaddr = (unsigned char *)
kmap_atomic(sg_page(sg), KM_USER0);
Expand All @@ -623,10 +623,10 @@ static int fill_from_dev_buffer(struct scsi_cmnd * scp, unsigned char * arr,
}
req_len += sg->length;
}
if (scsi_get_resid(scp))
scsi_set_resid(scp, scsi_get_resid(scp) - act_len);
if (sdb->resid)
sdb->resid -= act_len;
else
scsi_set_resid(scp, req_len - act_len);
sdb->resid = req_len - act_len;
return 0;
}

Expand All @@ -643,8 +643,7 @@ static int fetch_to_dev_buffer(struct scsi_cmnd * scp, unsigned char * arr,
return 0;
if (NULL == scsi_sglist(scp))
return -1;
if (! ((scp->sc_data_direction == DMA_BIDIRECTIONAL) ||
(scp->sc_data_direction == DMA_TO_DEVICE)))
if (!(scsi_bidi_cmnd(scp) || scp->sc_data_direction == DMA_TO_DEVICE))
return -1;
req_len = fin = 0;
scsi_for_each_sg(scp, sg, scsi_sg_count(scp), k) {
Expand Down

0 comments on commit 9207230

Please sign in to comment.