Skip to content

Commit

Permalink
xen: don't call dpm_resume_noirq() with interrupts disabled.
Browse files Browse the repository at this point in the history
dpm_resume_noirq() takes a mutex, so it can't be called from a no-interrupt
context.  Don't call it from within the stop-machine function, but just
afterwards, since we're resuming anyway, regardless of what happened.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Stable Kernel <stable@kernel.org>
  • Loading branch information
Jeremy Fitzhardinge committed Dec 3, 2009
1 parent 499d19b commit 922cc38
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/xen/manage.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ static int xen_suspend(void *data)
if (err) {
printk(KERN_ERR "xen_suspend: sysdev_suspend failed: %d\n",
err);
dpm_resume_noirq(PMSG_RESUME);
return err;
}

Expand All @@ -69,7 +68,6 @@ static int xen_suspend(void *data)
}

sysdev_resume();
dpm_resume_noirq(PMSG_RESUME);

return 0;
}
Expand Down Expand Up @@ -108,6 +106,9 @@ static void do_suspend(void)
}

err = stop_machine(xen_suspend, &cancelled, cpumask_of(0));

dpm_resume_noirq(PMSG_RESUME);

if (err) {
printk(KERN_ERR "failed to start xen_suspend: %d\n", err);
goto out;
Expand All @@ -119,8 +120,6 @@ static void do_suspend(void)
} else
xs_suspend_cancel();

dpm_resume_noirq(PMSG_RESUME);

resume_devices:
dpm_resume_end(PMSG_RESUME);

Expand Down

0 comments on commit 922cc38

Please sign in to comment.