Skip to content

Commit

Permalink
PCI : remove too specialized __pci_enable_device for default resume
Browse files Browse the repository at this point in the history
Original patch was posted as "PCI : Move pci_fixup_device and is_enabled".
This 1 of 3 patches does:

  - reverts small part of Inaky's patch
    (remove __pci_enable_device)
    This change will be recovered by 3rd patch.

  - temporarily remove pci_fixup_device.
    This change will be recovered by 2nd patch.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Hidetoshi Seto authored and Greg Kroah-Hartman committed Feb 7, 2007
1 parent 07eddf3 commit 924b08f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 25 deletions.
2 changes: 1 addition & 1 deletion drivers/pci/pci-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ static int pci_default_resume(struct pci_dev *pci_dev)
pci_restore_state(pci_dev);
/* if the device was enabled before suspend, reenable */
if (atomic_read(&pci_dev->enable_cnt))
retval = __pci_enable_device(pci_dev);
retval = pci_enable_device(pci_dev);
/* if the device was busmaster before the suspend, make it busmaster again */
if (pci_dev->is_busmaster)
pci_set_master(pci_dev);
Expand Down
23 changes: 0 additions & 23 deletions drivers/pci/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -700,29 +700,6 @@ pci_enable_device_bars(struct pci_dev *dev, int bars)
return 0;
}

/**
* __pci_enable_device - Initialize device before it's used by a driver.
* @dev: PCI device to be initialized
*
* Initialize device before it's used by a driver. Ask low-level code
* to enable I/O and memory. Wake up the device if it was suspended.
* Beware, this function can fail.
*
* Note this function is a backend and is not supposed to be called by
* normal code, use pci_enable_device() instead.
*/
int
__pci_enable_device(struct pci_dev *dev)
{
int err;

err = pci_enable_device_bars(dev, (1 << PCI_NUM_RESOURCES) - 1);
if (err)
return err;
pci_fixup_device(pci_fixup_enable, dev);
return 0;
}

/**
* pci_enable_device - Initialize device before it's used by a driver.
* @dev: PCI device to be initialized
Expand Down
1 change: 0 additions & 1 deletion drivers/pci/pci.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/* Functions internal to the PCI core code */

extern int __must_check __pci_enable_device(struct pci_dev *);
extern int pci_uevent(struct device *dev, char **envp, int num_envp,
char *buffer, int buffer_size);
extern int pci_create_sysfs_dev_files(struct pci_dev *pdev);
Expand Down

0 comments on commit 924b08f

Please sign in to comment.