Skip to content

Commit

Permalink
netxen: Fix bug in Tx completion path.
Browse files Browse the repository at this point in the history
o Driver is not updating sw_consumer while processing Tx completion
  when interface is going down. Due to this interface down path gets
  stuck forever waiting for NAPI to complete.

Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Manish Chopra authored and David S. Miller committed Sep 30, 2014
1 parent 0d36882 commit 9295f94
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -1794,9 +1794,9 @@ int netxen_process_cmd_ring(struct netxen_adapter *adapter)
break;
}

if (count && netif_running(netdev)) {
tx_ring->sw_consumer = sw_consumer;
tx_ring->sw_consumer = sw_consumer;

if (count && netif_running(netdev)) {
smp_mb();

if (netif_queue_stopped(netdev) && netif_carrier_ok(netdev))
Expand Down

0 comments on commit 9295f94

Please sign in to comment.