Skip to content

Commit

Permalink
KVM: MMU: Rename the walk label in walk_addr_generic()
Browse files Browse the repository at this point in the history
The current name does not explain the meaning well.  So give it a better
name "retry_walk" to show that we are trying the walk again.

This was suggested by Ingo Molnar.

Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
  • Loading branch information
Takuya Yoshikawa authored and Avi Kivity committed Jul 12, 2011
1 parent 134291b commit 92c1c1e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/x86/kvm/paging_tmpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,

trace_kvm_mmu_pagetable_walk(addr, write_fault, user_fault,
fetch_fault);
walk:
retry_walk:
eperm = false;
walker->level = mmu->root_level;
pte = mmu->get_cr3(vcpu);
Expand Down Expand Up @@ -211,7 +211,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
if (unlikely(ret < 0))
goto error;
else if (ret)
goto walk;
goto retry_walk;

mark_page_dirty(vcpu->kvm, table_gfn);
pte |= PT_ACCESSED_MASK;
Expand Down Expand Up @@ -277,7 +277,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
if (unlikely(ret < 0))
goto error;
else if (ret)
goto walk;
goto retry_walk;

mark_page_dirty(vcpu->kvm, table_gfn);
pte |= PT_DIRTY_MASK;
Expand Down

0 comments on commit 92c1c1e

Please sign in to comment.