Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 14847
b: refs/heads/master
c: 220ec70
h: refs/heads/master
i:
  14845: 4435881
  14843: c62beb0
  14839: 1d6e1ee
  14831: ea9ab8d
  14815: 176e96f
  14783: 2c090f6
  14719: 029f646
  14591: 0d7116b
  14335: 17c1129
v: v3
  • Loading branch information
Len Brown committed Dec 1, 2005
1 parent 0f122f3 commit 92d0216
Show file tree
Hide file tree
Showing 8 changed files with 50 additions and 10 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 1cbf4c563c0eaaf11c552a88b374e213181c6ddd
refs/heads/master: 220ec706645ecf13ee3a87046d17316303905698
7 changes: 7 additions & 0 deletions trunk/arch/i386/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,13 @@ static int __init acpi_parse_fadt(unsigned long phys, unsigned long size)
return 0;

pmtmr_ioport = fadt->xpm_tmr_blk.address;
/*
* "X" fields are optional extensions to the original V1.0
* fields, so we must selectively expand V1.0 fields if the
* corresponding X field is zero.
*/
if (!pmtmr_ioport)
pmtmr_ioport = fadt->V1_pm_tmr_blk;
} else {
/* FADT rev. 1 */
pmtmr_ioport = fadt->V1_pm_tmr_blk;
Expand Down
1 change: 0 additions & 1 deletion trunk/drivers/acpi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ config ACPI_ASUS
config ACPI_IBM
tristate "IBM ThinkPad Laptop Extras"
depends on X86
default y
---help---
This is a Linux ACPI driver for the IBM ThinkPad laptops. It adds
support for Fn-Fx key combinations, Bluetooth control, video
Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/acpi/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ EXTRA_CFLAGS += $(ACPI_CFLAGS)
# ACPI Boot-Time Table Parsing
#
obj-y += tables.o
obj-y += blacklist.o
obj-$(CONFIG_X86) += blacklist.o

#
# ACPI Core Subsystem (Interpreter)
Expand Down
15 changes: 15 additions & 0 deletions trunk/drivers/acpi/processor_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,8 @@ static int acpi_processor_get_info(struct acpi_processor *pr)
return_VALUE(0);
}

static void *processor_device_array[NR_CPUS];

static int acpi_processor_start(struct acpi_device *device)
{
int result = 0;
Expand All @@ -561,6 +563,19 @@ static int acpi_processor_start(struct acpi_device *device)

BUG_ON((pr->id >= NR_CPUS) || (pr->id < 0));

/*
* Buggy BIOS check
* ACPI id of processors can be reported wrongly by the BIOS.
* Don't trust it blindly
*/
if (processor_device_array[pr->id] != NULL &&
processor_device_array[pr->id] != (void *)device) {
ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "BIOS reporting wrong ACPI id"
"for the processor\n"));
return_VALUE(-ENODEV);
}
processor_device_array[pr->id] = (void *)device;

processors[pr->id] = pr;

result = acpi_processor_add_fs(device);
Expand Down
29 changes: 24 additions & 5 deletions trunk/drivers/acpi/processor_idle.c
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,16 @@ static void acpi_processor_idle(void)

cx->usage++;

#ifdef CONFIG_HOTPLUG_CPU
/*
* Check for P_LVL2_UP flag before entering C2 and above on
* an SMP system. We do it here instead of doing it at _CST/P_LVL
* detection phase, to work cleanly with logical CPU hotplug.
*/
if ((cx->type != ACPI_STATE_C1) && (num_online_cpus() > 1) &&
!pr->flags.has_cst && acpi_fadt.plvl2_up)
cx->type = ACPI_STATE_C1;
#endif
/*
* Sleep:
* ------
Expand Down Expand Up @@ -534,6 +544,15 @@ static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
pr->power.states[ACPI_STATE_C0].valid = 1;
pr->power.states[ACPI_STATE_C1].valid = 1;

#ifndef CONFIG_HOTPLUG_CPU
/*
* Check for P_LVL2_UP flag before entering C2 and above on
* an SMP system.
*/
if ((num_online_cpus() > 1) && acpi_fadt.plvl2_up)
return_VALUE(-ENODEV);
#endif

/* determine C2 and C3 address from pblk */
pr->power.states[ACPI_STATE_C2].address = pr->pblk + 4;
pr->power.states[ACPI_STATE_C3].address = pr->pblk + 5;
Expand Down Expand Up @@ -690,7 +709,7 @@ static int acpi_processor_get_power_info_cst(struct acpi_processor *pr)

/* Validate number of power states discovered */
if (pr->power.count < 2)
status = -ENODEV;
status = -EFAULT;

end:
acpi_os_free(buffer.pointer);
Expand Down Expand Up @@ -841,11 +860,11 @@ static int acpi_processor_get_power_info(struct acpi_processor *pr)
* this function */

result = acpi_processor_get_power_info_cst(pr);
if ((result) || (acpi_processor_power_verify(pr) < 2)) {
if (result == -ENODEV)
result = acpi_processor_get_power_info_fadt(pr);
if ((result) || (acpi_processor_power_verify(pr) < 2))
result = acpi_processor_get_power_info_default_c1(pr);
}

if ((result) || (acpi_processor_power_verify(pr) < 2))
result = acpi_processor_get_power_info_default_c1(pr);

/*
* Set Default Policy
Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/acpi/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,7 @@ acpi_add_single_object(struct acpi_device **child,
*
* TBD: Assumes LDM provides driver hot-plug capability.
*/
result = acpi_bus_find_driver(device);
acpi_bus_find_driver(device);

end:
if (!result)
Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/acpi/video.c
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ acpi_video_device_write_brightness(struct file *file,

ACPI_FUNCTION_TRACE("acpi_video_device_write_brightness");

if (!dev || count + 1 > sizeof str)
if (!dev || !dev->brightness || count + 1 > sizeof str)
return_VALUE(-EINVAL);

if (copy_from_user(str, buffer, count))
Expand Down

0 comments on commit 92d0216

Please sign in to comment.